Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean / string parameter support #274

Closed

Conversation

kaixoo
Copy link

@kaixoo kaixoo commented Oct 21, 2024

Implements #59

@kaixoo
Copy link
Author

kaixoo commented Oct 21, 2024

@rodlie I see that the issue about adding boolean support is more about using a checkbox in the UI instead of a number? (as per MaurycyLiebner#323)

@rodlie
Copy link
Member

rodlie commented Oct 22, 2024

I see that the issue about adding boolean support is more about using a checkbox in the UI instead of a number?

Shader effects that want a boolean param should get a boolean param (we have boolean param, must be exposed to shader plugins like other params).

Example:

<Property name="invert" nameUI="Invert" type="int" min="0" max="1" ini="0" step ="1" glValue="true"/>

@rodlie
Copy link
Member

rodlie commented Oct 22, 2024

@kaixoo kaixoo closed this Oct 30, 2024
@kaixoo kaixoo reopened this Nov 13, 2024
@kaixoo kaixoo closed this Nov 13, 2024
@kaixoo kaixoo reopened this Nov 13, 2024
@kaixoo kaixoo closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants