Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"macOS Duplicating keyframes duplicates objects too" fix #358

Closed
wants to merge 9 commits into from

Conversation

pgilfernandez
Copy link

It was pretty easy to fix following your previous work.

It fixes #357

@pgilfernandez pgilfernandez marked this pull request as draft December 3, 2024 16:11
@rodlie
Copy link
Member

rodlie commented Dec 3, 2024

hmm, must have forgotten to commit as I had this fix on my macbook during testing. Will cherry-pick your commit later today as this PR is a bit messy.

@pgilfernandez
Copy link
Author

Umm, set it up as draft as it looks like this "simple fix" is blocking other shortcuts (create markers, set in and out...)
I'm exploring it more in depth...

@rodlie
Copy link
Member

rodlie commented Dec 3, 2024

Umm, set it up as draft as it looks like this "simple fix" is blocking

Ok, will check on my macbook later today, I remember testing duplicate and it worked(?), maybe I'm mistaken.

@pgilfernandez
Copy link
Author

Oh, man, I didn't realize about this mess... it was supposed to just be commit 8c0a308... the other ones must come from my local messy repository... sorry about it.
If you find the fix, just apply it on your own... forget my poor trials, hehehe

@rodlie
Copy link
Member

rodlie commented Dec 3, 2024

Commit 8c0a308 works here.

@pgilfernandez
Copy link
Author

Then my branch got corrupted with all that rubbish... let me try with a clean one and confirm it works too for me.

@pgilfernandez
Copy link
Author

Commit 8c0a308 works here.

BTW, does it works and markers and set in/out continue to work?

@rodlie
Copy link
Member

rodlie commented Dec 3, 2024

Commit 8c0a308 works here.

BTW, does it works and markers and set in/out continue to work?

Yes, but duplicate object are now kind of broken. Will need to debug this further.

@rodlie
Copy link
Member

rodlie commented Dec 3, 2024

#324 (comment)

Note that there might be more broken shortcuts on macOS.

yeah... famous last words. Delete is also broken. Assume everything with NoShortcutAction is broken on macOS.

Yes, but duplicate object are now kind of broken. Will need to debug this further.

This is an issue with focus canvas vs. timeline it seems (got a fix).

@rodlie
Copy link
Member

rodlie commented Dec 3, 2024

#324

@rodlie rodlie closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS - Duplicating keyframes duplicates objects too
2 participants