-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"macOS Duplicating keyframes duplicates objects too" fix #358
Conversation
hmm, must have forgotten to commit as I had this fix on my macbook during testing. Will cherry-pick your commit later today as this PR is a bit messy. |
Umm, set it up as draft as it looks like this "simple fix" is blocking other shortcuts (create markers, set in and out...) |
Ok, will check on my macbook later today, I remember testing duplicate and it worked(?), maybe I'm mistaken. |
Oh, man, I didn't realize about this mess... it was supposed to just be commit 8c0a308... the other ones must come from my local messy repository... sorry about it. |
Commit 8c0a308 works here. |
Then my branch got corrupted with all that rubbish... let me try with a clean one and confirm it works too for me. |
BTW, does it works and markers and set in/out continue to work? |
Yes, but duplicate object are now kind of broken. Will need to debug this further. |
yeah... famous last words. Delete is also broken. Assume everything with
This is an issue with focus canvas vs. timeline it seems (got a fix). |
It was pretty easy to fix following your previous work.
It fixes #357