Skip to content

Commit

Permalink
build: disable musl release build until #456 is fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
@fujiapple852
fujiapple852 committed Mar 25, 2023
1 parent 3d135bf commit f9af087
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,11 @@ jobs:
RUST_BACKTRACE: 1
strategy:
matrix:
build: [linux-gnu, linux-musl, linux-arm, macos, netbsd, win-msvc]
build: [linux-gnu, linux-arm, macos, netbsd, win-msvc]
include:
- build: linux-gnu
os: ubuntu-22.04
target: x86_64-unknown-linux-gnu
- build: linux-musl
os: ubuntu-22.04
target: x86_64-unknown-linux-musl
- build: linux-arm
os: ubuntu-22.04
target: aarch64-unknown-linux-gnu
Expand Down

3 comments on commit f9af087

@chenrui333
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it is good to have a VERSION meta doc so that the version would be taken care of between the releases.

relates to Homebrew/homebrew-core#127190

@fujiapple852
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrui333 yes a VERSION file is a good idea. Are Homebrew version bumps created automatically for each GH release or manually triggered?

@chenrui333
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenrui333 yes a VERSION file is a good idea. Are Homebrew version bumps created automatically for each GH release or manually triggered?

it can be done in that way :) (you can use https://github.com/mislav/bump-homebrew-formula-action)

Please sign in to comment.