-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable build of dynamic linked library #76
Conversation
@kawakami-k Initial review would be helpful. Can also:
|
Hi, @bkmgit Xbyak_aarch64 is a very low-level library that manipulates the instruction-level code. Even if a single instruction generated by Xbyak_aarch64 is different from the one expected by applications linking with Xbyak_aarch64, it can causes serious bugs. To avoid this situation, I think it is safe to provide Xbyak_aarch64 as a static library. |
@kawakami-k Thanks for your feedback. Fedora prefers to ship dynamically linked libraries where possible so that improvements can be easily incorporated in end user applications without recompilation of the application, even though there is a performance overhead. Can carry the patch to make a dynamic library, but if it is possible to incorporate it and include testing of the dynamic library it would be very helpful. Happy to refactor the Makefile to make it cleaner. The original xbyak is header only, and so similar to a static library, but can look at updating this as well to make a dynamically linked library. Many of the other JIT compilers are rather large, so this is very helpful in constrained environments. |
@bkmgit , @kawakami-k |
@herumi @bkmgit |
@kawakami-k |
Thanks. Will close this pull request then. Using CMake is ok. |
Partially addressing #74