Add caching to DemuxFastqs #764
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh13
commented
Jan 27, 2022
| @@ -787,6 +793,11 @@ private class FastqDemultiplexer(val sampleInfos: Seq[SampleInfo], | |||
| private val sampleInfosNoUnmatched = sampleInfos.filterNot(_.isUnmatched) | |||
| private val unmatchedSample = sampleInfos.find(_.isUnmatched).getOrElse(throw new IllegalArgumentException("No unmatched sample provided.")) | |||
|
|
|||
| private val cache = if (this.cacheSize == 0) None else { | |||
| logger.info(f"Using cache of size: $cacheSize") | |||
| Some(new LeastRecentlyUsedCache[ArraySeq[Byte], (SampleInfo, Int)](maxEntries=cacheSize)) | |||
There was a problem hiding this comment.
TODO: make thread safe with threadlocal
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 114 114
Lines 6733 6743 +10
Branches 429 424 -5
=======================================
+ Hits 6428 6438 +10
Misses 305 305
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.