-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sinon-chai to the latest version 🚀 #19
Open
greenkeeper
wants to merge
1
commit into
master
Choose a base branch
from
greenkeeper/sinon-chai-2.12.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.0.0 just got published.Update to this version instead 🚀 Release Notes3.0.0
|
Version 3.1.0 just got published.Update to this version instead 🚀 Release Notes3.1.0Added support for Sinon v5.x+. (@dostu, #122) Added |
Version 3.2.0 just got published.Update to this version instead 🚀 Release Notes3.2.0Added support for Sinon v6.x. (@mattbaileyuk, #127) |
Update to this version instead 🚀 Release Notes for 3.4.0https://github.com/domenic/sinon-chai/blob/master/CHANGELOG.md#340 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.12.0 of sinon-chai just got published.
The version 2.12.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of sinon-chai.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
2.12.0Added colored diff formatting to calledWith and friends, like
sinon.assert()
got (in Sinon 2.0).Commits
The new version differs by 2 commits.
d5d47c6
2.12.0
48d2408
Add improved diffing for calledWith and friends
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴