MM-62085: Handle nil post priority (mattermost#29496)

https://mattermost.atlassian.net/browse/MM-62085 ```release-note NONE ```
fume4mattermost · Dec 6, 2024 · e6c0ed4 · e6c0ed4
1 parent b034092
commit e6c0ed4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/server/public/model/post.go b/server/public/model/post.go
@@ -935,6 +935,10 @@ func (o *Post) IsUrgent() bool {
 		return false
 	}
 
+	if postPriority.Priority == nil {
+		return false
+	}
+
 	return *postPriority.Priority == PostPriorityUrgent
 }
 

diff --git a/server/public/model/post_test.go b/server/public/model/post_test.go
@@ -977,3 +977,16 @@ func TestPostForPlugin(t *testing.T) {
 		require.NotNil(t, pluginPost.GetProp("requested_features"))
 	})
 }
+
+func TestPostPriority(t *testing.T) {
+	p := &Post{
+		Metadata: &PostMetadata{},
+	}
+	require.False(t, p.IsUrgent())
+
+	p.Metadata.Priority = &PostPriority{}
+	require.False(t, p.IsUrgent())
+
+	p.Metadata.Priority.Priority = NewPointer(PostPriorityUrgent)
+	require.True(t, p.IsUrgent())
+}