Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computer use issues #58

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Fix computer use issues #58

merged 2 commits into from
Nov 3, 2024

Conversation

ptrkstr
Copy link
Contributor

@ptrkstr ptrkstr commented Nov 2, 2024

Version matching

Computer use only works with a newer model version of sonnet

Tool encoding

Tools were being encoded as:

"tools": [
  {
    "computer": {
      "_0": {
        "display_height_px": 768,
        "display_number": 1,
        "display_width_px": 1024,
        "type": "computer_20241022",
        "name": "computer"
      }
    }
  }
],

But they should be encoded as

"tools": [
  {
    "display_number": 1,
    "name": "computer",
    "type": "computer_20241022",
    "display_width_px": 1024,
    "display_height_px": 768
  }
],

Copy link
Owner

@fumito-ito fumito-ito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptrkstr
Copy link
Contributor Author

ptrkstr commented Nov 3, 2024

I have fixed the failing test 😅

@fumito-ito fumito-ito merged commit 4d0ba35 into fumito-ito:main Nov 3, 2024
1 check passed
fumito-ito added a commit that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants