Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Project Creation form to be consistent with new requirements (6th November 2021) #262

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AVS1508
Copy link
Member

@AVS1508 AVS1508 commented Nov 7, 2021

This PR is intended to fix #260 as well as fix #261.

Requirements

  • Make video links mandatory in the Project Creation page
  • Change functionality of wall outlet field in project creation form to verify whether the user is participating virtually

Changelog

  • Updated the Project model to validate the presence and format of YouTube link [validates the format of the youtube_link (allowed to be blank so that it doesn't show 2 errors if absent as we're already validating its presence above) if it is indeed present because it needs to start with https://]
  • Updated the Project Creation view to be consistent with model changes and new requirements
  • Updated the Project creation form view to have the checkbox for virtual participants [Note that the question now asks for confirmation of being a virtual participant and not the wall outlet requirement so while this may not be the best practice for long term development, I am leaving the form field as supplying the :power symbol in the interest of not wrangling with model changes and creating updated migrations in the middle of the event.]

Individual Views

Functionality Views/Demos

Before Project Submission View (with filled data)

Pre-Submit

Absent youtube_link field Submission View (with filled data)

Absent Field

Incorrectly formatted youtube_link field Submission View (with filled data)

Incorrect Format

Successful New Project Submission (with filled data)

Successful.Submission.mov

Final Project Creation Form View

Final View

@AVS1508 AVS1508 requested a review from CodyRichter November 7, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant