Consider preferring the standard AWS env vars if set

[eriknelson]

A lot of the AWS tools respect the following env vars if found, over others:

AWS_ACCESS_KEY_ID="XXX"
AWS_SECRET_ACCESS_KEY="XXX"
AWS_DEFAULT_REGION="us-west-1"

I changed my env var's default region and couldn't figure out why the terminate playbook couldn't find an instance that I clearly had in us-west-1. Turns out my config.yaml file with the ansible vars was actually what was being used, and it was set to us-west-2.

Would it make sense to accept these env vars overall else, or is that not really a fair assumption I'm making?

[jmontleon]

With most of the ec2 modules you can use the env vars if the parameters are otherwise unset:
https://docs.ansible.com/ansible/latest/modules/ec2_module.html

https://docs.ansible.com/ansible/latest/modules/ec2_module.html#notes

I don't see AWS_DEFAULT_REGION in the list, but AWS_REGION and EC2_REGION at the least are valid. All you'd have to do is remove them from our config.yml if we kill this, I believe, and maybe comment out the region set in the config.yml.example by default.

https://github.com/fusor/origin3-dev/blob/master/ansible/roles/ec2_provision/defaults/main.yml#L7
https://github.com/fusor/origin3-dev/blob/master/config.yml.example#L12

And update the use for the change: https://github.com/fusor/origin3-dev#use

I'm fine with it if it makes others lives easier.

[jmontleon]

I guess there's a handful of tasks we'd have to adjust as well:
https://github.com/fusor/origin3-dev/search?q=%22%7B%7B+ec2_region+%7D%7D%22&unscoped_q=%22%7B%7B+ec2_region+%7D%7D%22