Use Env for AWS region, fix 2.8 deprecation warnings #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbladilo FYI, this may affect CI wrt to using the environment variable for region. |
|
Addresses #37 |
|
You're welcome. I'd just like to give Franco and @Danil-Grigorev a chance to see it before merging so we don't break CI on them unexpectedly. |
|
Yeah, that's why I didn't want to merge it right away. I'm certainly not
blocked by this, just thought it could be an improvement.
…On Thu, May 23, 2019 at 12:29 PM Jason Montleon ***@***.***> wrote:
You're welcome. I'd just like to give Franco and @Danil-Grigorev
<https://github.com/Danil-Grigorev> a chance to see it before merging so
we don't break CI on them unexpectedly.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#38?email_source=notifications&email_token=AADEKNLC3NQRT7L5LP6DSODPW3A4VA5CNFSM4HPGK5LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWCYS3I#issuecomment-495290733>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADEKNLFDLVC4YA3K22SCJLPW3A4VANCNFSM4HPGK5LA>
.
|
fbladilo
approved these changes
May 24, 2019
Cool. Sounds good. I'll wait until at least Monday so you have a chance and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.