Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SN30 Pro+ v3.02 firmware #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhansen
Copy link
Contributor

@rhansen rhansen commented Dec 31, 2019

I ran make and manually installed the resulting .cab but got an error. Despite the error it seemed to update successfully. Output of fwupdmgr:

$ sudo fwupdmgr install ./8Bitdo-SN30_Pro+-3.02.cab                    
Decompressing…           [***************************************]                          
Authenticating…          [***************************************]
Installing on 8Bitdo…    [ -                                     ]
Writing…                 [***************************************] Less than one minute remaining…
failed to get ACK for mark firmware as successful: failed to retrieve from device on ep 0x82: USB error on device 2dc8:5750 : No such device (it may have been disconnected) [-4]

@hughsie
Copy link
Member

hughsie commented Dec 31, 2019

Despite the error it seemed to update successfully

If you use something like 1.3.2 then https://github.com/fwupd/fwupd/blob/master/plugins/ebitdo/ebitdo.quirk#L91 should apply to ignore the warning. What fwupd version are you testing with?

@rhansen
Copy link
Contributor Author

rhansen commented Dec 31, 2019

L91 should apply to ignore the warning.

L89 says USB ID 2DC8:6002, but when the controller is in firmware update mode (L+R+Start), which is required for fwupd get-devices to see the controller, the USB ID is 2DC8:5750.

What fwupd version are you testing with?

I'm using fwupd v1.3.5.

@rhansen
Copy link
Contributor Author

rhansen commented Dec 31, 2019

Some other things I've observed:

  • I think a few other 8BitDo controllers (such as the non-plus version of the SN30 Pro) also use USB ID 2DC8:5750 when in bootloader (firmware update) mode.
  • When the SN30 Pro+ is in firmware update mode (L+R+Start), fwupd get-updates shows
    $ sudo fwupdmgr get-updates
    No upgrades for 8Bitdo, current is 3.02: 1.10=older
    
    I would have expected it to show 3.01=older. The only 8BitDo firmware with version 1.10 I see at LVFS is for the M30. Is it incorrectly detecting the device?

Edit: I filed fwupd/fwupd#1681 regarding issues detecting the SN30 Pro+.

@rhansen
Copy link
Contributor Author

rhansen commented Jan 7, 2020

Friendly ping.

@rhansen rhansen force-pushed the sn30-pro-plus-3.02 branch 2 times, most recently from f2e8a97 to 87bcf5f Compare February 12, 2020 20:43
@rhansen rhansen changed the title Add SN30 Pro+ v3.02 firmware Add SN30 Pro+ v3.02 firmware and fix GUIDs Feb 12, 2020
@rhansen
Copy link
Contributor Author

rhansen commented Mar 1, 2020

Ping?

@hughsie
Copy link
Member

hughsie commented Mar 2, 2020

Ping?

Does the new firmware archive actually work now? Thanks.

@rhansen
Copy link
Contributor Author

rhansen commented Mar 6, 2020

Does the new firmware archive actually work now? Thanks.

The new firmware works, but updating the device via fwupd doesn't work due to fwupd/fwupd#1681 (which should be reopened).

@rhansen rhansen force-pushed the sn30-pro-plus-3.02 branch from 87bcf5f to 1cc9ea8 Compare April 12, 2020 16:57
@rhansen rhansen mentioned this pull request Apr 12, 2020
@rhansen rhansen force-pushed the sn30-pro-plus-3.02 branch 2 times, most recently from 93ae812 to e141f50 Compare April 14, 2020 01:00
@rhansen rhansen force-pushed the sn30-pro-plus-3.02 branch from e141f50 to d79d2ad Compare April 15, 2020 02:08
@rhansen rhansen changed the title Add SN30 Pro+ v3.02 firmware and fix GUIDs Add SN30 Pro+ v3.02 firmware Apr 15, 2020
@hughsie
Copy link
Member

hughsie commented Apr 15, 2020

I'm not sure what to do here. 8bitdo stopped uploading firmware on their own some time ago. I suppose I could ask them if they are happy if someone else is responsible for this, but I'd obviously need a volunteer to co-ordinate this (who isn't me).

@superm1
Copy link
Member

superm1 commented Apr 15, 2020

I'm not sure what to do here. 8bitdo stopped uploading firmware on their own some time ago. I suppose I could ask them if they are happy if someone else is responsible for this, but I'd obviously need a volunteer to co-ordinate this (who isn't me).

Or at least a robot that scraped their page to make new CABs to throw in testing would be another option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants