Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor based on testcontainers-go module recomendations #17

Closed
wants to merge 6 commits into from

Conversation

gAmUssA
Copy link
Owner

@gAmUssA gAmUssA commented Aug 10, 2023

  • refactoring
  • Refactored code to align with testcontainers-go module recomendations

@gAmUssA gAmUssA force-pushed the feat/viktor/tc_go_module branch from 2621f28 to ec97863 Compare August 10, 2023 02:59
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Test Results

1 files  2 suites   1m 11s ⏱️
4 tests 3 ✔️ 0 💤 1
5 runs  3 ✔️ 0 💤 2

For more details on these failures, see this check.

Results for commit 9b75534.

♻️ This comment has been updated with latest results.

gAmUssA added 2 commits August 9, 2023 23:41
adding wait condition
using oss image
@mdelapenya
Copy link
Collaborator

Let me take a deeper look and will post here my comments! Great to see progress in the Kong module.

Once done, we can publish it to our website here: https://github.com/testcontainers/community-module-registry/ (example)

@mdelapenya
Copy link
Collaborator

mdelapenya commented Aug 10, 2023

Quick question: why kong image does not come with /usr/local/kong/go-plugins/bin already created by default? If that dir is widely used, then I think it should be already there, right?

UPDATE: Kong/docker-kong#667 😄

@gAmUssA
Copy link
Owner Author

gAmUssA commented Aug 10, 2023

@mdelapenya it looks like /usr/local/bin should potentially work

https://docs.konghq.com/gateway/latest/plugin-development/pluginserver/plugins-kubernetes/

Let me try

@mdelapenya
Copy link
Collaborator

it looks like /usr/local/bin should potentially work

I'm also working locally in a PR to your branch 🤝

@gAmUssA
Copy link
Owner Author

gAmUssA commented Aug 10, 2023

@mdelapenya 9b75534 uses image (not docker build)

@mdelapenya
Copy link
Collaborator

I get this error:

2023/08/10 16:06:17 [debug] 1321#0: [lua] plugins.lua:284: load_plugin(): Loading plugin: grpc-web
2023/08/10 16:06:18 [error] 1321#0: init_by_lua error: /usr/local/share/lua/5.1/kong/init.lua:652: error parsing declarative config file /usr/local/kong/kong.yaml:
in 'services':
  - in entry 1 of 'services':
    in 'plugins':
      - in entry 1 of 'plugins':
        in 'name': plugin 'goplug' not enabled; add it to the 'plugins' configuration property
stack traceback:
        [C]: in function 'error'
        /usr/local/share/lua/5.1/kong/init.lua:652: in function 'init'
        init_by_lua:3: in main chunk
nginx: [error] init_by_lua error: /usr/local/share/lua/5.1/kong/init.lua:652: error parsing declarative config file /usr/local/kong/kong.yaml:
in 'services':
  - in entry 1 of 'services':
    in 'plugins':
      - in entry 1 of 'plugins':
        in 'name': plugin 'goplug' not enabled; add it to the 'plugins' configuration property
stack traceback:
        [C]: in function 'error'
        /usr/local/share/lua/5.1/kong/init.lua:652: in function 'init'
        init_by_lua:3: in main chunk
Error: /usr/local/share/lua/5.1/kong/cmd/start.lua:98: failed to start nginx (exit code: 1)

  Run with --v (verbose) or --vv (debug) for more details

I've set up the env vars, and copied the files to the places 🤔

@gAmUssA
Copy link
Owner Author

gAmUssA commented Aug 10, 2023

@mdelapenya update your local branch. I pushed 9b75534 with update

@mdelapenya
Copy link
Collaborator

Reference for wasm plugins: Kong/proxy-wasm-go-rate-limiting#1

@gAmUssA
Copy link
Owner Author

gAmUssA commented Sep 19, 2023

closed by #18

@gAmUssA gAmUssA closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants