Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nov updates #87

Merged
merged 12 commits into from
Dec 11, 2024
Merged

Nov updates #87

merged 12 commits into from
Dec 11, 2024

Conversation

nsheff
Copy link
Member

@nsheff nsheff commented Nov 13, 2024

Codifying some recent decisions in the ADR and specification.

Specifically, this PR makes these changes:

  • adds ADR for transient and passthru attributes
  • adds new section to the spec for 'attribute qualifiers', which adds new information about passthru/transient attributes and also groups this with descriptions of inherent/collated qualifiers
  • adds 'name_length_pairs' description as a RECOMMENDED attribute
  • updates schema definitions to put attribute qualifiers under a 'ga4gh' key (Alignment: inherent property #84)
  • fixes some links
  • adds ADR for new 'minimal schema' where we changed the list of required/inherent attributes, and also updates the example schemas in the spec.

@nsheff
Copy link
Member Author

nsheff commented Nov 20, 2024

Question:

Should we specify the qualifiers for the custom attributes?

sorted_sequences

  • inherent: false
  • collated: false
  • passthru: false
  • transient: false

sorted_name_length_pairs

  • inherent: false
  • collated: false
  • passthru: false
  • transient: true

name_length_pairs

  • inherent: false
  • collated: true
  • passthru: false
  • transient: false

Or are some of these allowed to vary by implementation?

@nsheff nsheff marked this pull request as ready for review November 20, 2024 19:45
@nsheff nsheff requested review from tcezard and sveinugu December 10, 2024 17:36
@nsheff nsheff merged commit b994915 into dev Dec 11, 2024
@nsheff nsheff deleted the nov-updates branch December 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants