Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make VRS schema release info accessible in VRS-Python #467

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Nov 27, 2024

close #85

  • use a hook during setup to grab the most recent release tag from the VRS submodule, then write it as an importable Python module (not necessarily the most elegant way to do this, but I think it's the only realistic option)
  • This draft uses the scheme used by setuptools-scm](https://setuptools-scm.readthedocs.io/en/latest/usage/#default-versioning-scheme) to append commit hash/rev distance when the most recent tag isn't applied to the checked-out commit. I assume that the VRS submodule is tied to a branch and not a tag/commit due to its development status, and maybe this will be unnecessary once that stabilizes.
  • ...not totally sure why this is failing in GH actions. It seems like git can return exit code 128 for a few reasons, and it's a little challenging to know why, but that'll obviously need to be resolved.
  • very, very low priority. Was just something I was thinking about yesterday.

@jsstevenson jsstevenson added the priority:low Low priority label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retrieve schema version
1 participant