Fix setParameterValue bug

[luzhuang]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

• New Features

  • Enhanced the animator's parameter handling, allowing for more frequent updates to parameter values when set.

• Bug Fixes

  • Simplified logic for updating parameter values, ensuring that any valid parameter will trigger an update in the animation system.

[coderabbitai]

Walkthrough

The update to the setParameterValue method in the Animator class simplifies the logic for updating the _parametersValueMap. Previously, the update only occurred if the new value differed from the default. Now, if a parameter exists, the method updates the map with the new value, enhancing flexibility in parameter handling and potentially altering animator behavior when setting parameters.

Changes

Files	Change Summary
packages/core/src/animation/Animator.ts	Simplified conditional logic in setParameterValue method to update _parametersValueMap with any new value for existing parameters, regardless of default value.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Animator
    participant ParameterMap

    User->>Animator: setParameterValue(parameter, value)
    Animator->>ParameterMap: Check if parameter exists
    ParameterMap-->>Animator: Parameter exists
    Animator->>ParameterMap: Update value
    ParameterMap-->>Animator: Value updated
    Animator-->>User: Confirmation of update

Loading

Poem

🐇 In the meadow where bunnies play,
With parameters set in a brand new way,
No more worries of default's sway,
Just hop and change, we’ll dance and say,
"Hooray for flexibility, hip-hip-hooray!" 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 31245db and 521e072.

Files selected for processing (1)

• packages/core/src/animation/Animator.ts (1 hunks)

Additional comments not posted (1)

packages/core/src/animation/Animator.ts (1)

248-250: LGTM! But verify the impact of the simplified condition.

The simplified condition enhances flexibility by updating _parametersValueMap whenever the parameter exists. However, this might lead to more frequent updates. Ensure that this change does not negatively impact performance or introduce unintended side effects.