Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to polkadot-v1.1.0 #645

Merged
merged 63 commits into from
Jan 12, 2024
Merged

chore: upgrade to polkadot-v1.1.0 #645

merged 63 commits into from
Jan 12, 2024

Conversation

Roznovjak
Copy link
Collaborator

@Roznovjak Roznovjak commented Oct 20, 2023

TODO:

  • use XYK and LBP pallets from hydra
  • rebenchmark all pallets
  • storage migrations
  • test runtime upgrade (try-runtime and chopsticks)
  • update main README file

Our stuff:

  • XCMP defer queue
  • XCM executor atomicity
  • Tinkernet
  • Democracy pallet
  • rust 1.71 compatibily with Zombienet (UnknownOpcode(192))

Notable changes:

  • Deprecate Weight::from_ref_time and Weight::from_proof_size and use from_parts instead
  • The try-runtime subcommand has been migrated to a standalone CLI #14731
  • XCM Topics - XCM messages are uniquely referenceable
  • BlockNumber removed from frame_system::Config. Use frame_system::BlockNumberFor<T>. #14437
  • Default config parameters #13454

API changes:

  • pallet_balances #12951
    • set_balance becomes force_set_balance
    • transfer becomes transfer_allow_death

This release removes the following CLI parameters:

--rpc-max-payload (replaced by --rpc-max-request-size and --rpc-max-response-size)
--ws-max-out-buffer-capacity
--ws-external (replaced by --rpc-external)
--unsafe-ws-external (replaced by --unsafe-rpc-external)
--ipc--path
--ws-port (replaced by --rpc-port)
--ws-max--connections (replaced by --rpc-max-connections)
--rpc-http (replaced by --rpc-addr)
--rpc-ws (replaced by --rpc-addr)

@Roznovjak Roznovjak self-assigned this Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Crate versions that have been updated:

  • runtime-integration-tests: v0.9.15 -> v1.0.1
  • basilisk: v10.0.1 -> v11.0.0
  • pallet-marketplace: v5.0.15 -> v5.0.17
  • pallet-xyk-liquidity-mining: v1.1.8 -> v1.1.10
  • pallet-xyk-liquidity-mining-benchmarking: v1.0.15 -> v1.0.16
  • primitives: v6.5.0 -> v6.6.0
  • basilisk-runtime: v106.0.0 -> v108.0.0

Runtime version has been increased.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 776 lines in your changes are missing coverage. Please review.

Comparison is base (fb09976) 49.67% compared to head (2a34fa7) 32.28%.
Report is 12 commits behind head on master.

❗ Current head 2a34fa7 differs from pull request most recent head 10ff31e. Consider uploading reports for the commit 10ff31e to get more accurate results

Files Patch % Lines
runtime/basilisk/src/assets.rs 2.63% 111 Missing ⚠️
node/src/service.rs 0.00% 107 Missing ⚠️
runtime/basilisk/src/weights/democracy.rs 0.00% 102 Missing ⚠️
runtime/basilisk/src/weights/collective.rs 0.00% 77 Missing ⚠️
runtime/basilisk/src/weights/collator_selection.rs 0.00% 40 Missing ⚠️
runtime/basilisk/src/weights/lbp.rs 0.00% 36 Missing ⚠️
runtime/basilisk/src/weights/scheduler.rs 0.00% 33 Missing ⚠️
runtime/basilisk/src/weights/tips.rs 0.00% 28 Missing ⚠️
runtime/basilisk/src/migrations.rs 0.00% 26 Missing ⚠️
runtime/basilisk/src/weights/balances.rs 13.33% 26 Missing ⚠️
... and 18 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #645       +/-   ##
===========================================
- Coverage   49.67%   32.28%   -17.40%     
===========================================
  Files          60       51        -9     
  Lines        3867     3166      -701     
===========================================
- Hits         1921     1022      -899     
- Misses       1946     2144      +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Roznovjak Roznovjak marked this pull request as ready for review November 16, 2023 12:22
@Roznovjak Roznovjak requested a review from mrq1911 November 17, 2023 14:58
@@ -1,3 +1,6 @@
// Runtimes with enabled `runtime-benchmarks` feature behave differently.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure that integration tests are still ran in CI, separately if necessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy is affected by this. I updated the makefile command to run clippy twice, with and without -all-features, to cover everything.

integration-tests/src/xcm_rate_limiter.rs Show resolved Hide resolved
node/src/cli.rs Show resolved Hide resolved
node/src/service.rs Outdated Show resolved Hide resolved
node/src/service.rs Outdated Show resolved Hide resolved
runtime/basilisk/src/governance.rs Show resolved Hide resolved
runtime/basilisk/src/governance.rs Outdated Show resolved Hide resolved
runtime/basilisk/src/xcm.rs Outdated Show resolved Hide resolved
runtime/basilisk/src/xcm.rs Outdated Show resolved Hide resolved
runtime/basilisk/src/xcm.rs Show resolved Hide resolved
@mrq1911 mrq1911 merged commit d28315c into master Jan 12, 2024
4 checks passed
@Roznovjak Roznovjak deleted the polkadot-v1.1.0 branch January 12, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants