Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: XCM Rate Limiter Integration #638

Merged
merged 28 commits into from
Jan 20, 2024
Merged

feat!: XCM Rate Limiter Integration #638

merged 28 commits into from
Jan 20, 2024

Conversation

apopiak
Copy link
Contributor

@apopiak apopiak commented Jul 12, 2023

Adds the XCM rate limit pallet from #561 into the runtime.
Updates the XCMP queue pallet to the version from galacticcouncil/cumulus#4

Checklist:

  • I have updated the documentation if necessary.
  • I have added tests to cover my changes, regression test if fixing an issue.
  • This is a breaking change.

@apopiak apopiak requested review from mrq1911 and dmoka July 12, 2023 10:19
@apopiak apopiak requested a review from jak-pan July 12, 2023 16:54
@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Crate versions that have been updated:

  • runtime-integration-tests: v1.13.0 -> v1.13.1
  • pallet-xcm-rate-limiter: v0.1.1 -> v0.1.2
  • hydradx-runtime: v183.0.0 -> v184.0.0

Runtime version has been increased.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1e488d4) 69.32% compared to head (658b7be) 68.24%.
Report is 474 commits behind head on master.

❗ Current head 658b7be differs from pull request most recent head d958f16. Consider uploading reports for the commit d958f16 to get more accurate results

Files Patch % Lines
pallets/xcm-rate-limiter/src/lib.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
- Coverage   69.32%   68.24%   -1.09%     
==========================================
  Files         163      156       -7     
  Lines       12991    11789    -1202     
==========================================
- Hits         9006     8045     -961     
+ Misses       3985     3744     -241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrq1911 mrq1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets test this on 🐍 1st

}

#[test]
fn xcm_rate_limiter_should_limit_aca_when_limit_is_exceeded() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably also test clearing of the limits in similar fashion after blocks pass

@jak-pan
Copy link
Contributor

jak-pan commented Sep 25, 2023

Hmm where is the latest version of rate limiter? @apopiak

@Roznovjak Roznovjak merged commit 6c88813 into master Jan 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants