Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add more lm wrappers #953

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

feat: add more lm wrappers #953

wants to merge 39 commits into from

Conversation

dmoka
Copy link
Contributor

@dmoka dmoka commented Nov 26, 2024 •
edited
Loading

Further dicusiions:

  • add positions- in case of empty array, we dont do anything with farms

in case of remove, we need

Add two more extrinsics:

  • add_liquidity_with_limit_and_join_farms
  • add_liquidity_stableswap_omnipool_and_join_farms

In order to make UX better on FE

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Crate versions that have been updated:

  • runtime-integration-tests: v1.26.0 -> v1.27.0
  • pallet-omnipool: v4.3.7 -> v4.3.8
  • pallet-omnipool-liquidity-mining: v2.5.0 -> v2.6.0
  • pallet-stableswap: v4.1.1 -> v4.1.2
  • pallet-staking: v4.0.1 -> v4.0.2
  • runtime-mock: v1.0.2 -> v1.0.3
  • hydradx-runtime: v277.0.0 -> v278.0.0
  • hydradx-traits: v3.10.0 -> v3.11.0

Runtime version has been increased.

@dmoka dmoka marked this pull request as ready for review December 4, 2024 09:27
@dmoka dmoka changed the title Feat: add more lm wrappers feat: add more lm wrappers Dec 4, 2024
jak-pan
jak-pan reviewed Dec 6, 2024
View reviewed changes
integration-tests/src/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
integration-tests/src/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
pallets/omnipool-liquidity-mining/src/benchmarks.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has been replaced to hydradx/src/benchmarking because we need more dependencies (stableswap) to fulfull the benchmarking

pallets/omnipool-liquidity-mining/src/lib.rs Show resolved Hide resolved
pallets/omnipool-liquidity-mining/src/lib.rs Outdated Show resolved Hide resolved
integration-tests/src/omnipool_liquidity_mining.rs Show resolved Hide resolved
runtime/hydradx/src/benchmarking/omnipool_liquidity_mining.rs Show resolved Hide resolved
martinfridrich
martinfridrich reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@martinfridrich martinfridrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do full review, just what i saw because I was mentioned

pallets/omnipool-liquidity-mining/src/lib.rs Outdated Show resolved Hide resolved
pallets/omnipool-liquidity-mining/src/lib.rs Show resolved Hide resolved
pallets/omnipool-liquidity-mining/src/lib.rs Outdated Show resolved Hide resolved
martinfridrich
martinfridrich reviewed Dec 30, 2024
View reviewed changes
pallets/omnipool-liquidity-mining/src/lib.rs Outdated Show resolved Hide resolved
integration-tests/src/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
integration-tests/src/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
integration-tests/src/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
integration-tests/src/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
integration-tests/src/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
integration-tests/src/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
pallets/omnipool-liquidity-mining/src/tests/mock.rs Outdated Show resolved Hide resolved
runtime/hydradx/src/benchmarking/mod.rs Show resolved Hide resolved
runtime/hydradx/src/benchmarking/omnipool_liquidity_mining.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jak-pan jak-pan jak-pan left review comments

@martinfridrich martinfridrich martinfridrich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmoka @martinfridrich @jak-pan