When bumping the galaxy metapackage, also bump its galaxy-* deps and include/update pinned-requirements.txt #23
Conversation
…include/update pinned-requirements.txt
| for line in content: | ||
| if line.startswith("version = "): | ||
| line = f"version = {new_version}" | ||
| elif line.startswith("install_requires ="): |
There was a problem hiding this comment.
This seems kind of weird to execute on all packages. Do you need to first determine if this is the meta package ?
There was a problem hiding this comment.
(Also any reason we don't symlink the requirements file ?)
There was a problem hiding this comment.
Also, can we have this in a separate function? A function called bump_package_version shouldn't be overwriting package requirements, I think. Besides, we call it twice, and we don't want to have to do this new work twice (or each time we need to update the version number of a package). No to mention ease of testing..
There was a problem hiding this comment.
(Also any reason we don't symlink the requirements file ?)
Setuptools does not use this automatically, does it? Apparently since 62.6 you can specify it in setup.cfg with:
install_requires = file: requirements.txtbut this can't be combined with the list syntax we need to specify the galaxy-* subpackages (and the --index-url is invalid for setuptools as well).
There was a problem hiding this comment.
Also, can we have this in a separate function?
Sure. I did it here because we were already modifying the file here, so you know, didn't want to incur the performance penalty of reading/writing a 1 KB file twice 😆 but agree it's not in scope for the function.
|
Please don't merge before #25. I can help with fixing the conflicts. |
xref galaxyproject/galaxy#19051