Ignore empty lines, comments when reading in packages_by_dep_dag.txt file #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jdavcs
force-pushed
the
main_package_dag_process
branch
from
9fcf9cb to
5a95e7f
Compare
mvdbeek
reviewed
Feb 2, 2024
mvdbeek
reviewed
Feb 2, 2024
mvdbeek
reviewed
Feb 2, 2024
|
Can you undo the session changes ? tmp_path is a python fixture, it is virtually free to create a temp dir for isolated tests. Also the pytest config looks weird to me, can you delete that too please ? |
mvdbeek
force-pushed
the
main_package_dag_process
branch
from
0861e51 to
02ff377
Compare
|
Thanks, the test is much simpler now. About |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add test; use session-scoped fixtures not to regenerate the same files for each test.