-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. updates to script #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Feel free to drop the 3.7 tests |
jdavcs
force-pushed
the
main_galaxy_root
branch
from
February 20, 2024 20:28
0ad8e62
to
e66e31b
Compare
@mvdbeek did you mean drop 3.7 with mypy and lint? I've added a run under 3.12 with lint and removed mypy altogether - it was giving me too much of a hard time. I don't mind adding it back right away (or, better, after fixing all issues) |
jdavcs
force-pushed
the
main_galaxy_root
branch
from
February 21, 2024 23:11
68fe4eb
to
05590bc
Compare
martenson
approved these changes
Feb 22, 2024
Yes, can you please add back mypy to 3.8? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure_branches_up_to_date()
, the rest is my guess. Otherwise those git commands will be executed against the current directory, which is going to be different when--galaxy-root
is passed.lib
dir here)I have tested this by using it for creating the 23.2.1 point release.