Skip to content

Commit

Permalink
Merge pull request #18694 from jdavcs/24.1_admin_sort_last_login
Browse files Browse the repository at this point in the history
[24.1] Fix sorting users in admin by last login
  • Loading branch information
mvdbeek authored Aug 13, 2024
2 parents 0bc1a46 + 886cd1b commit 1f0984e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/galaxy/webapps/galaxy/controllers/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def sort(self, trans, query, ascending, column_name=None):
.group_by(model.GalaxySession.table.c.user_id)
.subquery()
)
query = query.outerjoin((last_login_subquery, model.User.table.c.id == last_login_subquery.c.user_id))
query = query.outerjoin(last_login_subquery, model.User.table.c.id == last_login_subquery.c.user_id)

if not ascending:
query = query.order_by((last_login_subquery.c.last_login).desc().nullslast())
Expand Down

0 comments on commit 1f0984e

Please sign in to comment.