Skip to content

Commit

Permalink
Avoid object store path lookup when constructing JobState object
Browse files Browse the repository at this point in the history
This eliminates the code path that failed in
#18189, and should
generally be a nice performance improvement.
  • Loading branch information
mvdbeek committed May 21, 2024
1 parent 37551f5 commit 51fbc18
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/galaxy/jobs/runners/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -678,14 +678,16 @@ def __init__(self, job_wrapper: "JobWrapper", job_destination: "JobDestination")
self.job_wrapper = job_wrapper
self.job_destination = job_destination
self.runner_state = None
self.exit_code_file = default_exit_code_file(job_wrapper.working_directory, job_wrapper.get_id_tag())

self.redact_email_in_job_name = True
if self.job_wrapper:
self.redact_email_in_job_name = self.job_wrapper.app.config.redact_email_in_job_name

self.cleanup_file_attributes = ["job_file", "output_file", "error_file", "exit_code_file"]

@property
def exit_code_file(self) -> str:
return default_exit_code_file(self.job_wrapper.working_directory, self.job_wrapper.get_id_tag())

def set_defaults(self, files_dir):
if self.job_wrapper is not None:
id_tag = self.job_wrapper.get_id_tag()
Expand Down

0 comments on commit 51fbc18

Please sign in to comment.