Skip to content

Commit

Permalink
Merge pull request #17596 from bernt-matthias/data_manager_data_path
Browse files Browse the repository at this point in the history
Automatically bind `galaxy_data_manager_data_path` in containers
  • Loading branch information
mvdbeek authored May 8, 2024
2 parents 1bb139a + 8045855 commit 890a47b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions lib/galaxy/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ def _configure_toolbox(self):
galaxy_root_dir=galaxy_root_dir,
default_file_path=file_path,
tool_data_path=self.config.tool_data_path,
galaxy_data_manager_data_path=self.config.galaxy_data_manager_data_path,
shed_tool_data_path=self.config.shed_tool_data_path,
outputs_to_working_directory=self.config.outputs_to_working_directory,
container_image_cache_path=self.config.container_image_cache_path,
Expand Down
3 changes: 3 additions & 0 deletions lib/galaxy/tool_util/deps/container_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ def add_var(name, value):
add_var("default_file_path", self.app_info.default_file_path)
add_var("library_import_dir", self.app_info.library_import_dir)
add_var("tool_data_path", self.app_info.tool_data_path)
add_var("galaxy_data_manager_data_path", self.app_info.galaxy_data_manager_data_path)
add_var("shed_tool_data_path", self.app_info.shed_tool_data_path)

if self.job_info.job_directory and self.job_info.job_directory_type == "pulsar":
Expand Down Expand Up @@ -376,6 +377,8 @@ def add_var(name, value):
defaults += ",$library_import_dir:default_ro"
if self.app_info.tool_data_path:
defaults += ",$tool_data_path:default_ro"
if self.app_info.galaxy_data_manager_data_path:
defaults += ",$galaxy_data_manager_data_path:default_ro"
if self.app_info.shed_tool_data_path:
defaults += ",$shed_tool_data_path:default_ro"

Expand Down
2 changes: 2 additions & 0 deletions lib/galaxy/tool_util/deps/dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def __init__(
galaxy_root_dir: Optional[str] = None,
default_file_path: Optional[str] = None,
tool_data_path: Optional[str] = None,
galaxy_data_manager_data_path: Optional[str] = None,
shed_tool_data_path: Optional[str] = None,
outputs_to_working_directory: bool = False,
container_image_cache_path: Optional[str] = None,
Expand All @@ -35,6 +36,7 @@ def __init__(
self.galaxy_root_dir = galaxy_root_dir
self.default_file_path = default_file_path
self.tool_data_path = tool_data_path
self.galaxy_data_manager_data_path = galaxy_data_manager_data_path
self.shed_tool_data_path = shed_tool_data_path
# TODO: Vary default value for docker_volumes based on this...
self.outputs_to_working_directory = outputs_to_working_directory
Expand Down

0 comments on commit 890a47b

Please sign in to comment.