Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invocation control looks odd #19158

Closed
mvdbeek opened this issue Nov 18, 2024 · 2 comments · Fixed by #19168
Closed

Invocation control looks odd #19158

mvdbeek opened this issue Nov 18, 2024 · 2 comments · Fixed by #19168

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Nov 18, 2024

Screenshot 2024-11-18 at 17 38 50

The empty area left and right of the progress component looks weird, and the Waiting to complete invocation seems kind of unnecessary if we have the progress bar anyway. The blue background there also seems odd. Finally the Generate PDF button ... is redundant with the one in reports ?

@ahmedhamidawan ahmedhamidawan self-assigned this Nov 19, 2024
ahmedhamidawan added a commit to ahmedhamidawan/galaxy that referenced this issue Nov 20, 2024
Used to be in the `tabs-end` slot. Here, we remove it from there and the BAlert and instead:
- The icon on the top left is a loading one when workflow is running
- The cancel button is next to the progress bars
- We remove the "Generate PDF" button entirely

Fixes galaxyproject#19158
@ahmedhamidawan
Copy link
Member

Would you rather the progress bars be even narrower in width, or be wider all the way to either end?

@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 26, 2024

Looks good with #19168

@mvdbeek mvdbeek closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants