[24.2] Move invocation view running actions and improve styling of annotation section #19168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to be in the `tabs-end` slot. Here, we remove it from there and the BAlert and instead: - The icon on the top left is a loading one when workflow is running - The cancel button is next to the progress bars - We remove the "Generate PDF" button entirely Fixes galaxyproject#19158
martenson
reviewed
Nov 20, 2024
client/src/components/WorkflowInvocationState/WorkflowInvocationState.vue
Outdated
Show resolved
Hide resolved
itisAliRH
reviewed
Nov 20, 2024
ahmedhamidawan
changed the title
In the grid version, we don't have the `WorkflowNavigationTitle` and `WorkflowAnnotation` components, and one of those has the workflow cancel button, which could be useful in the grid as well.
This reverts the change in commit 632955a We realized (in galaxyproject#19157) we didn't really need this in the run form version of `WorkflowAnnotation` because there this acts as an indicator of whatever the "input" history is; which is just your current history and users can see that anyways.
Fixes galaxyproject#19157 where we notice that the description could be full width instead of truncated half way, as well as the need for a visual distinction between the run form and the header annotation.
and add it to `WorkflowNavigationTitle` where it fades out to reveal the title and actions
which is based on whether it is the run form or invocation view Tests changes from commit 6dd5f7c
ahmedhamidawan
changed the title
since the progress bars already indicate that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions for a currently running workflow were added in the
tabs-endslot in #18615 Here, we remove controls from there and theBAlertand instead:next to the progress barsnow in the title actions (next to the Play button)Fixes #19158
Also lets the workflow description/annotation take up full width, and adds a
<hr>below it to separate from the run form.Fixes #19157
How to test the changes?
(Select all options that apply)
License