Move history multiview item actions to top #18265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamidawan
force-pushed
the
multiview_top_bar
branch
from
0a64281 to
e4bf56d
Compare
ahmedhamidawan
changed the title
|
Very cool! |
ahmedhamidawan
force-pushed
the
multiview_top_bar
branch
3 times, most recently
from
d33d461 to
8ce94b5
Compare
|
@davelopez This should take care of
|
davelopez
reviewed
Jul 23, 2024
client/src/components/History/CurrentHistory/HistoryDetails.vue
Outdated
Show resolved
Hide resolved
ahmedhamidawan
force-pushed
the
multiview_top_bar
branch
2 times, most recently
from
c386dd9 to
c2adaf6
Compare
davelopez
reviewed
Jul 25, 2024
client/src/components/History/CurrentHistory/HistoryNavigation.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/CurrentHistory/HistoryNavigation.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/CurrentHistory/HistoryNavigation.vue
Outdated
Show resolved
Hide resolved
client/src/components/History/CurrentHistory/HistoryDetails.vue
Outdated
Show resolved
Hide resolved
Adds a `pinnedHistoriesSummarizedStatus` computed ref to `historyStore` that Returns a string that indicates whether all the pinned histories have annotations, tags, both, or none of them. This is used to then adjust the `DetailsLayout` header height accordingly.
Add `HistoryNavigation` to the top section as well. WIP: There is a bug right now that applies the dropdown action to all pinned histories in multiview (e.g.: You try to delete a history from the dropdown, but a modal opens up for each pinned history
Using `v-b-modal:modal-id` had the disadvantage that if we had multiple components containing modals with same ids, they would all open simultaneously. Using `v-modal` to open modals instead removes this side effect.
So that the dropdown item says "Purge this history" instead of delete for a history that is already deleted.
Move summarized type to its own file as well.
Co-authored-by: David López <[email protected]>
ahmedhamidawan
force-pushed
the
multiview_top_bar
branch
from
cafbd29 to
f5cc111
Compare
To use updated message for permanently deleted history
davelopez
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Awesome! Thank you so much @ahmedhamidawan for addressing all the comments!
It looks great!
I've added a last commit to adapt the unit test message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pinnedHistoriesSummarizedStatuscomputed ref tohistoryStorethat Returns a string that indicates whether all the pinned histories have annotations, tags, both, or none of them. This is used to then adjust theDetailsLayoutheader height accordingly.Fixes #18210
How to test the changes?
(Select all options that apply)
License