Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.09] pin celery to 5.2.3 #18477

Closed
wants to merge 1 commit into from
Closed

[21.09] pin celery to 5.2.3 #18477

wants to merge 1 commit into from

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Jul 1, 2024 •
edited
Loading

  • prior to 5.2.3 the pinning for pytz in celery was pytz>0.dev.0 or pytz>dev which now creates problems:
  • we updated the pinning to 5.2.3 in 22.01 anyway

see also #18472 and https://pradyunsg.me/blog/2024/05/13/pip-24-1-betas/

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias
pin celery to 5.2.3
e1b81d0 
- prior to [5.2.3](https://github.com/celery/celery/blame/v5.2.3/requirements/default.txt#L1) the pinning for pytz in celery was `pytz>0.dev.0` or `pytz>dev` which now creates problems:
- we updated the pinning to 5.2.3 in 22.01 anyway

see also galaxyproject#18472
and https://pradyunsg.me/blog/2024/05/13/pip-24-1-betas/
@mvdbeek
Copy link
Member

mvdbeek commented Jul 1, 2024

Given we're doing this for planemo, would it instead make sense to bump up the versions of Galaxy we test planemo against ?

@bernt-matthias
Copy link
Contributor Author

Given we're doing this for planemo, would it instead make sense to bump up the versions of Galaxy we test planemo against ?

Indeed. Do you know if we have a strategy? One and two years back?

@bernt-matthias
Copy link
Contributor Author

xref galaxyproject/planemo#1466

@bernt-matthias bernt-matthias mentioned this pull request Jul 2, 2024
Merged
@bernt-matthias bernt-matthias deleted the 21.09-celery-5.2.3 branch July 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernt-matthias @mvdbeek