-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip galaxy filename annotation on upload #18561
base: dev
Are you sure you want to change the base?
Strip galaxy filename annotation on upload #18561
Conversation
The forced confirmation dialogue isn't ideal here.
|
Used our existing strip_galaxy_filename_annotation_on_upload.mp4This is still a dialog that though can be dismissed easily, is still kinda in your way... might try something else if this isn't quite right |
@ahmedhamidawan I like how the message box appropriately pops up within the confirmDialog component. TY for that one! |
- Uses a helper isGalaxyFile() to check for Galaxy file syntax. - Handles the rename gracefully with a confirmation pop-up.
- Added `html` option to `confirmDialog` to allow for HTML message - The `uploadPayload` method had to be made an async one due to the confirm option.
78062a7
to
ca6c38d
Compare
Issue #17642
How to test the changes?
(Select all options that apply)
License