Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip galaxy filename annotation on upload #18561

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

GomeChas
Copy link

@GomeChas GomeChas commented Jul 18, 2024

Issue #17642

galaxy_queue confirmation result

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests. Wishing for guidance on the tests still...
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.2 milestone Jul 18, 2024
@ahmedhamidawan ahmedhamidawan self-requested a review November 12, 2024 15:52
@ahmedhamidawan
Copy link
Member

The forced confirmation dialogue isn't ideal here.
A better alternative could be a Toast that has a button/link in it?
Examples of Toasts being used are in components with the import:

import { Toast } from "@/composables/toast";

@jdavcs jdavcs modified the milestones: 24.2, 25.0 Nov 20, 2024
@ahmedhamidawan
Copy link
Member

ahmedhamidawan commented Dec 10, 2024

Used our existing confirmDialog composable here instead:

strip_galaxy_filename_annotation_on_upload.mp4

This is still a dialog that though can be dismissed easily, is still kinda in your way... might try something else if this isn't quite right

@GomeChas
Copy link
Author

@ahmedhamidawan I like how the message box appropriately pops up within the confirmDialog component. TY for that one!

GomeChas and others added 7 commits December 11, 2024 12:47
- Uses a helper isGalaxyFile() to check for Galaxy file syntax.

- Handles the rename gracefully with a confirmation pop-up.
- Added `html` option to `confirmDialog` to allow for HTML message
- The `uploadPayload` method had to be made an async one due to the confirm option.
@ahmedhamidawan ahmedhamidawan force-pushed the strip_galaxy_filename_annotation_on_upload branch from 78062a7 to ca6c38d Compare December 11, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants