Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlobToolkit to the list of interactive tools #18630

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Delphine-L
Copy link
Contributor

Hi, I'd like to get the Interactive BlobToolkit to the list of interactive tools and get in on main. Let me know if there is a better way to do that or if I am missing a step.

Tested on eu and it seems to be working fine.

Source : https://github.com/usegalaxy-eu/galaxy/blob/release_24.1_europe/tools/interactive/interactivetool_blobtoolkit.xml

How to test the changes?

  • Instructions for manual testing are as follows:
    1. Verify the tool is installed and working by following the GTN material ERGA post-assembly QC for example

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.2 milestone Jul 31, 2024
@Delphine-L
Copy link
Contributor Author

Could we install it without waiting for 24.2 when it's ready ?

@bgruening
Copy link
Member

Nate can always install it. If you want to have it here in 24.1 you need to target the release_24.1 branch.

Comment on lines +17 to +20
## The following is a hack. Our embedded pulsar is not respecting the Galaxy jwd-tmp dir.
export TEMP=\$PWD &&
export TMP=\$PWD &&
export TMPDIR=\$PWD &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this some old copy and paste ? If there is a problem with embeded pulsar and the temp dir handling issue should be opened.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgruening @kysrpex do you know where this originated from, is this still needed ?

@mvdbeek mvdbeek merged commit c42710a into galaxyproject:dev Sep 5, 2024
48 of 51 checks passed
Copy link

github-actions bot commented Sep 5, 2024

This PR was merged without a "kind/" label, please correct.

@Delphine-L Delphine-L deleted the blobtoolkit branch September 5, 2024 14:46
@cat-bro
Copy link
Contributor

cat-bro commented Sep 5, 2024

Thanks for adding this! A couple of Galaxy Australia users have been asking for it. Can this go onto the current release branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants