Fix tag processing in library upload

[davelopez]

Fixes #18700

It seems recent changes make uploaded_dataset contain the tags passed in the tool inputs. So before the recent changes, the place where the tags were processed was:

galaxy/lib/galaxy/tools/actions/upload_common.py

Line 274 in 64bd95d

tag_handler.apply_item_tag(

Because after the recent changes uploaded_dataset now has a tags attribute, the actual tag processing was done here:

galaxy/lib/galaxy/tools/actions/upload_common.py

Line 199 in 64bd95d

tag_handler.apply_item_tag(item=ldda, user=trans.user, name="name", value=tag, flush=False)

And this code path was assuming the tags were already parsed.

I think this is the correct fix. This code is old, but the bug was probably uncovered now while the first condition checking the library_bunch looked like a workaround. Let me know if that is not the case.

How to test the changes?

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[mvdbeek]

Looks good, thank you!