[24.1] Fix extra call to test_data_path that requires an admin key #19011

jmchilton · 2024-10-16T16:12:39Z

Regression introduced by @natefoo when he let 4a47efa get merged in without even reviewing it and catching this.

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
Run a tool test as a non-admin user against test.galaxyproject.org with and without this change.

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

davelopez · 2024-10-16T16:16:13Z

I knew it was @natefoo fault! 😅

natefoo · 2024-10-16T16:16:45Z

I'm so careless.

Fix extra call to test_data_path that requires an admin key

569eeb3

jmchilton added kind/bug area/testing area/tool-framework labels Oct 16, 2024

mvdbeek approved these changes Oct 16, 2024

View reviewed changes

jmchilton marked this pull request as ready for review October 16, 2024 19:18

github-actions bot added this to the 24.1 milestone Oct 16, 2024

jmchilton merged commit 666ab5e into galaxyproject:release_24.1 Oct 17, 2024
49 of 51 checks passed

nsoranzo deleted the fix_extra_call_to_test_data_path branch October 22, 2024 15:08