Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix very slow workflow editor loading #19068

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 28, 2024

Loading the editor for my usegalaxy.org account takes 20 seconds. I've narrowed this down to the unnecessary join against the workflow table and loading all steps. I'm also returning the needed columns directly.
The query is still about 1 second if the database cache is not hot (on consecutive execution the query finishes in ~ 7ms) with no obvious room for improvement (except for composite index), but I think with #18729 we might not have to load up the full list of workflows and step counts ahead of time anymore.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Loading the editor for my usegalaxy.org account takes 20 seconds. I've
narrowed this down to the unnecessary join against the workflow table
and loading all steps. I'm also returning the needed columns directly.
@github-actions github-actions bot added this to the 24.2 milestone Oct 28, 2024
@mvdbeek mvdbeek changed the base branch from dev to release_24.1 October 28, 2024 15:29
@ahmedhamidawan ahmedhamidawan merged commit 1042d38 into galaxyproject:release_24.1 Oct 29, 2024
57 checks passed
@jdavcs jdavcs removed this from the 24.2 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants