Avoid possible negative offset in LibraryFolder #19090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine, but should we also fix other similar cases on the client? I see these: |
jdavcs
approved these changes
Oct 31, 2024
|
@jdavcs I agree they should be checked for possible problems. But I wouldn't just blanket change them and this one did cause problems for sure. |
Checking makes sense, but it's just a basic pagination calculation, and your fix is a perfectly reasonable safeguard against a negative offset which, I think, should be applied uniformly to any pagination calculation. (I can take care of it if you like.) |
|
@jdavcs please feel free to |
ahmedhamidawan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
likely the culprit, closes #18043
License