Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OpenLayers legacy files and add SVG logo #19135

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Remove OpenLayers legacy files and add SVG logo #19135

merged 5 commits into from
Nov 13, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Nov 13, 2024

Follow-up for #19134. Removes unused legacy files, also allows svg logo to be displayed.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.2 milestone Nov 13, 2024
@guerler guerler marked this pull request as ready for review November 13, 2024 08:26
davelopez
davelopez approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining failures are unrelated and happening in other PRs, probably due to some dependency issue with parcel and buffer in combination with node version when building other visualizations.

@guerler guerler merged commit d3f179a into galaxyproject:dev Nov 13, 2024
44 of 49 checks passed
@guerler guerler deleted the openlayer_viz_cleanup branch November 13, 2024 13:59
@ahmedhamidawan ahmedhamidawan changed the title Openlayer cleanup, svg logo fix Remove OpenLayers Legacy Files and Add SVG Logo Nov 20, 2024
@ahmedhamidawan ahmedhamidawan changed the title Remove OpenLayers Legacy Files and Add SVG Logo Remove OpenLayers legacy files and add SVG logo Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/visualizations kind/enhancement
Projects
None yet
Milestone
24.2
Development

Successfully merging this pull request may close these issues.
2 participants
@guerler @davelopez