Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plotly.js #19206

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Add plotly.js #19206

merged 5 commits into from
Nov 27, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Nov 26, 2024 •
edited
Loading

plotly

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 25.0 milestone Nov 26, 2024
@guerler guerler marked this pull request as ready for review November 26, 2024 14:44
@itisAliRH itisAliRH self-requested a review November 27, 2024 11:19
itisAliRH
itisAliRH requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@itisAliRH itisAliRH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both formats work fine!
@guerler The icons are in SVG format but are not displaying properly. We need them in PNG format instead:
image

itisAliRH
itisAliRH approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@itisAliRH itisAliRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @guerler

@guerler guerler merged commit 4fd6535 into galaxyproject:dev Nov 27, 2024
53 checks passed
@guerler guerler deleted the plotly branch November 27, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itisAliRH itisAliRH itisAliRH approved these changes

Assignees
No one assigned
Labels
area/UI-UX area/visualizations kind/enhancement
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@guerler @itisAliRH