Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various invocation export issues #19207

Closed

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 26, 2024

Just want the tests here, the fixes should go to 24.0

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added the area/database Galaxy's database or data access layer label Nov 26, 2024
@jmchilton
Copy link
Member

Nice set of fixes, thanks for the work and the tests. Sorry about the bugs.

if the step is not a job step. This broke in galaxyproject@ab2f76c
where
```
                # Safeguard: imported_invocation_step was implicitly merged into this Session prior to SQLAlchemy 2.0.
                self.sa_session.add(imported_invocation_step)
```
was replaced with
```
ensure_object_added_to_session(imported_invocation, session=self.sa_session)
```
which seems like a small typo-like bug.
Without this change jobs like `__EXTRACT_DATASET__` would not be
included in a history or invocation export`.
@mvdbeek mvdbeek force-pushed the fix_various_invocation_export_issues branch from 8881c9d to ac44482 Compare November 27, 2024 16:30
@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 28, 2024

#19215 is the backported version

@mvdbeek mvdbeek closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants