Tool Request API #19231
Draft
Tool Request API #19231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
tool_request_api_try_3
branch
4 times, most recently
from
8ab958d to
2c06842
Compare
jmchilton
force-pushed
the
tool_request_api_try_3
branch
from
2c06842 to
6206bd0
Compare
jmchilton
force-pushed
the
tool_request_api_try_3
branch
from
6206bd0 to
d73b272
Compare
|
The mulled tests are broken for other reasons unrelated to this PR. It seems that Mamba 2.0 broke our tests. I think we can skip Mamba from the code base by now. I needed to do this today: BioContainers/multi-package-containers@062e5e0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at the tool request API (previous attempts in #18745, #18797) - it is a hard thing to get correct. Since the last attempt I realized that none of the newer style nested parameters had any of the map/reduce options of the original tool API so I had put a lot of work into fixing that with #19030. As part of that effort I worked on writing tool execution tests that targeted multiple APIs with the same (and new higher level) test code (work started in #18977 and continued with #19030). This PR is why I went down that path - to rapidly apply all those tests to the tool request API.
How to test the changes?
(Select all options that apply)
License