Code

Merge 24.2 into dev#19240

Code

Merged

jmchilton merged 185 commits intogalaxyproject:devgalaxyproject/galaxy:devfrom jmchilton:merge_24.2_into_devjmchilton/galaxy:merge_24.2_into_devCopy head branch name to clipboardDec 5, 2024

+3,528-2,069

Commits

Commits on Nov 21, 2024

• 24.2 release testing - UI tests for new workflow parameters

  jmchilton

  committed
  a05ec3f

Commits on Nov 27, 2024

• Merge pull request galaxyproject#19182 from jmchilton/selenium_24.2

  Show description for 2f7c1e5
  mvdbeek

  authored
  2f7c1e5

Commits on Nov 29, 2024

• Allow setting default value for required parameter

  mvdbeek

  committed
  433766e

• Remove now unused input_default_value property

  Show description for 0f5a89a
  mvdbeek

  committed
  0f5a89a

• Fix and add test for required workflow parameters with a default value

  Show description for 70a74c2
  mvdbeek

  committed
  70a74c2

• Adjust EmptyValueFilter

  mvdbeek

  committed
  6474ed1

• Extend tests

  mvdbeek

  committed
  8aa986f

• Replace explicit null with default value

  mvdbeek

  committed
  5d4e341

• Add test for default value with optional input

  mvdbeek

  committed
  59dc2a4

• Merge pull request galaxyproject#19219 from mvdbeek/required_parameters_with_default

  Show description for d4c2101
  jmchilton

  authored
  d4c2101

Commits on Dec 2, 2024

• This really stablizes these tests - they sort of runaway without this.

  

  jmchilton

  authored and

  ahmedhamidawan

  committed
  7cd2147

• fix pesky warning

  

  ElectronicBlueberry

  authored and

  ahmedhamidawan

  committed
  abe326a

• add button for creating a list from run form field

  Show description for d44f037
  ahmedhamidawan

  committed
  d44f037

• fully implement list collection creator in FormData

  Show description for 6d90374
  ahmedhamidawan

  committed
  6d90374

• add a maintain-selection-order prop to FormSelectMany

  Show description for 4b20276
  ahmedhamidawan

  committed
  4b20276

• fix reactivity of ClickToEdit and add some styling

  ahmedhamidawan

  committed
  0eaccd5

• ListCollectionCreator: add more types

  ahmedhamidawan

  committed
  f53170f

• modernize/refactor PairedListCollectionCreator for input forms

  Show description for 35ff19d
  ahmedhamidawan

  committed
  35ff19d

• remove the extensions toggle, only include isSubTypeOfAny items

  Show description for 6a504c0
  ahmedhamidawan

  committed
  6a504c0

• improve styling of collection create button in FormData

  Show description for 74234e0
  ahmedhamidawan

  committed
  74234e0

• change create new collection ButtonSpinner variant

  ahmedhamidawan

  committed
  6862f64

• change create new collection ButtonSpinner title; fix icon imports

  ahmedhamidawan

  committed
  297a529

• add history name to modal header

  ahmedhamidawan

  committed
  67f3105

• restrict the list:paired creator to required extensions

  ahmedhamidawan

  committed
  e844241

• make the "pairing" section in list:paired builder expand/collapseable

  ahmedhamidawan

  committed
  16c4eea

• add CollectionCreatorModal that replaces buildCollectionModal

  Show description for 8a9d9ac
  ahmedhamidawan

  committed
  8a9d9ac

• slight optimization

  Show description for b9f8f3c
  

  ahmedhamidawan

  and

  ElectronicBlueberry

  committed
  b9f8f3c

• (incomplete/WIP) add uploader to collection creator

  ahmedhamidawan

  committed
  3a827cc

• paired collection items are now also reversed like history

  ahmedhamidawan

  committed
  60a5fb7

• add uploaded files to collection directly

  Show description for fa572ad
  ahmedhamidawan

  committed
  fa572ad

• Fix jest collection modal test to be more flexible, allowing title content variability

  

  dannon

  authored and

  ahmedhamidawan

  committed
  b70f90c

• remove legacy JQuery collection creator modal files

  ahmedhamidawan

  committed
  99447d6

• fix PairedListCollectionCreator jest

  ahmedhamidawan

  committed
  c2ab795

• fix selectors for the changes to the collection builder

  Show description for 29796d4
  ahmedhamidawan

  committed
  29796d4

• do not show create another collection link if from selection

  ahmedhamidawan

  committed
  03527bd

Commits on Dec 3, 2024

• fix selection for collection creator in libraries

  ahmedhamidawan

  committed
  56ccef4

• fix reset function when creating collection from a selection

  ahmedhamidawan

  committed
  b9adc1b

• fix selection object for rule collection builder

  ahmedhamidawan

  committed
  e09a364

• ensure library import to collection modal closes

  Show description for 9deac09
  ahmedhamidawan

  committed
  9deac09

• Merge pull request galaxyproject#18857 from ahmedhamidawan/guide_users_to_collection_builder

  Show description for f5e146d
  dannon

  authored
  f5e146d

• generalize activity bar

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  06d870e

• add activity bar to workflow editor

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  f5b2cab

• add activities to activity bar

  Show description for 1ea75e1
  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1ea75e1

• add save and exit activity

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  ffc6e1d

• route to workflow list on exit

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  4747e87

• move best practices to activity bar

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  37b2d4e

• use ActivityPanel component for Lint

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  47f0ea3

• move UndoRedoStack to activity bar

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1436031

• add placeholder activities

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  f8b8fe9

• fix delayed input

  Show description for dc44c14
  

  ElectronicBlueberry

  authored and

  dannon

  committed
  dc44c14

• make favorites button reusable

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  b2aee86

• refactor WorkflowCard

  Show description for fdd3b11
  

  ElectronicBlueberry

  authored and

  dannon

  committed
  fdd3b11

• improve performance of workflow card

  Show description for 9ceee38
  

  ElectronicBlueberry

  authored and

  dannon

  committed
  9ceee38

• add workflows panel

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  02c7511

• fix z-indexing for dropdown

  Show description for 2cd580f
  

  ElectronicBlueberry

  authored and

  dannon

  committed
  2cd580f

• connect insert and insert steps events

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  c9e0483

• move breakpoints to partial

  Show description for ef8aab1
  

  ElectronicBlueberry

  authored and

  dannon

  committed
  ef8aab1

• only occupy vertical space if invocations count is present

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  377e0d5

• rename Attributes to WorkflowAttributes

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  62285a3

• make attributes an activity

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  fa4aa6d

• move MarkdownEditor to activity bar

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  dbe8d24

• move all options to activity bar

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  bb599c6

• add save button

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  136b68f

• remove unused attribute and unreachable code

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  89aad6a

• enable run and save

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  46f30b6

• fix activity text centering on chrome

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  12ad230

• fix text short property collision

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  b9d87a9

• decouple node inspector from right hand panel

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  32c60ce

• modularize drag handle

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1d4090f

• correct appearance of drag handle

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  7300e7b

• show collapse button

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  8522aaa

• add tool form to node inspector

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  8dca4d2

• add inspector heading

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  7f88c81

• allow for saving default sizes for tools / steps

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  6073a1d

• make double click maximize node inspector

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  ecbebaa

• fix scroll height

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  c04f53e

• add form default to inspector

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  ab5e901

• make form default full width

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  28c488c

• remove ability to sub-workflow own workflow

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  0fb7502

• connect refresh list signal

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  46a4c7b

• fix workflow creation

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  65dec1e

• make current workflow immutable from card

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  e2e65b1

• replace save with save and exit

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  ae58b8d

• add save button to title bar

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  0be4c1d

• move initial position to not interfere with toolbar

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  62b6ed2

• make step annotation resizable

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  60ef378

• fix activity item test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  f440a86

• fix workflow attributes test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  3bb365b

• fxi activity store test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  169496f

• fix empty divs rendered

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  47392d6

• fix activity settings test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  b191a19

• fix lint test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  c98a167

• fix filter conversion test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  5c6058d

• fix workflow filters import

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  3bddb47

• remove broken test case

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  01b2bb9

• remove workflows section in tool box

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  a478e03

• add back activity item id

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  9c94e66

• make workflow editor default to attributes

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1aebab7

• add class for editor save button

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  140d94e

• move selector to id

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1234a56

• fix auto layout

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1c1aea4

• add button titles to node inspector

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  869f561

• fix maximize center pane function

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  7b8e162

• make auto layout respect grid and snapping

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1ff3dc0

• make auto layout an action

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  f1c68dc

• make activity panel scrollable

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  88a24e6

• close inspector instead of showing attributes

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  7f98026

• open nodes from lint panel

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  2cd6b9b

• auto layout frame comments

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1d9df1d

• undo comment auto layout

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  cb10614

• consider comments in layout

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  13c9c77

• move freehand comments with their closest comment preserving large drawings

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  97dbde1

• fix edge crossing

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  88a88e4

• associate comments to their closest node

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  6fa52cb

• make auto layout a toolbar tool

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  e352336

• pass step position for more accurate comment positioning

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  a381310

• disable run button on new workflow

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  63aaaad

• Update client/src/components/ActivityBar/ActivityBar.vue

  Show description for b3b00ed
  

  itisAliRH

  authored and

  dannon

  committed
  b3b00ed

• Updates bookmark toggle function parameters

  Show description for 8103f7c
  

  itisAliRH

  authored and

  dannon

  committed
  8103f7c

• Removes non-existent config property usage

  Show description for eda1534
  

  itisAliRH

  authored and

  dannon

  committed
  eda1534

• Adds workflowId to useStores return object

  Show description for 95b4043
  

  itisAliRH

  authored and

  dannon

  committed
  95b4043

• Adds computed property for tools favorites toggle

  Show description for 5333a7b
  

  itisAliRH

  authored and

  dannon

  committed
  5333a7b

• Fixes FontAwesome icon usage in ToolPanel

  Show description for 4fc923c
  

  itisAliRH

  authored and

  dannon

  committed
  4fc923c

• Fix the test to check the shared indicator tooltip text

  

  itisAliRH

  authored and

  dannon

  committed
  995b226

• Adds Pinia testing support to ActivityItem tests and add required prop activityBarId

  

  itisAliRH

  authored and

  dannon

  committed
  d2e4a8a

• Updates workflow type to StoredWorkflowDetailed

  Show description for 8ee9806
  

  itisAliRH

  authored and

  dannon

  committed
  8ee9806

• Fixes import path and adds activity bar ID to NotificationItem

  Show description for d0d6c51
  

  itisAliRH

  authored and

  dannon

  committed
  d0d6c51

• Adds activity-bar-id prop to ActivityItem components

  Show description for 7aa575a
  

  itisAliRH

  authored and

  dannon

  committed
  7aa575a

• Adds favorites filter functionality to WorkflowPanel

  Show description for eaf09ba
  

  itisAliRH

  authored and

  dannon

  committed
  eaf09ba

• Refactors icon imports and usage

  Show description for f461d7c
  

  itisAliRH

  authored and

  dannon

  committed
  f461d7c

• Updates icon handling in tests

  Show description for 6640b28
  

  itisAliRH

  authored and

  dannon

  committed
  6640b28

• Updates filter keyword for workflow bookmarks

  Show description for 160d871
  

  itisAliRH

  authored and

  dannon

  committed
  160d871

• Simplifies activity item IDs

  Show description for b90c96b
  

  itisAliRH

  authored and

  dannon

  committed
  b90c96b

• Fix activity item upload progress background

  

  itisAliRH

  authored and

  dannon

  committed
  67cc231

• Adds ID to toolbox panel

  Show description for db252e3
  

  itisAliRH

  authored and

  dannon

  committed
  db252e3

• Adds auto-layout button ID in workflow toolbar

  Show description for 4b88521
  

  itisAliRH

  authored and

  dannon

  committed
  4b88521

• Adds hidePanel prop to ActivityBar and integrates MarkdownToolBox in MarkdownEditor

  Show description for 5d4af22
  

  itisAliRH

  authored and

  dannon

  committed
  5d4af22

• remove wait for absent element

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  7b3453a

• fix add_input

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  40b0e61

• fix inserting steps

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1b2fe7a

• fix tool menu container occurrences

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  b19cbe4

• Migrates WorkflowAttributes test to TypeScript and updates dependencies

  Show description for 5cb6784
  

  itisAliRH

  authored and

  dannon

  committed
  5cb6784

• fix workflows activity id

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  f6ec31a

• Migrates ToolPanel test to TypeScript

  Show description for da11b07
  

  itisAliRH

  authored and

  dannon

  committed
  da11b07

• Updates toolbox panel selectors and workflow editor logic

  Show description for c054c71
  

  itisAliRH

  authored and

  dannon

  committed
  c054c71

• Adds 'Save As' functionality to workflow editor

  

  itisAliRH

  authored and

  dannon

  committed
  a99a82a

• Adds 'Save As' option to workflow editor toolbar

  Show description for fec3214
  

  itisAliRH

  authored and

  dannon

  committed
  fec3214

• fix basics test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  fc5f2f0

• revert shortening of ids

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  5c02c41

• fix test save as

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  df4f7d4

• add more wait time for search

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  09bcf33

• re-add confirm dialog

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  263f0d6

• remove double id prepending

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  320a0f1

• redo add subworkflow

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  5b0150e

• fix save as selector

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  d9d1c15

• move selection options to the left, so they do not interfere with the node inspector

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  11519d4

• remove collapse buttons from basics test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  4a33bca

• wait for save to complete

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  21ceb30

• remove test for removed feature

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  b84ad70

• remove invalid check in insert steps

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  a16574a

• remove test for removed component

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  852fc4c

• make search selector more specific

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  b565fea

• fix selection test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  d899b92

• clear search before searching for other tool

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  5c8b958

• use confirm dialog composable

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  1dca036

• exclude node buttons from node selection targets

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  43ddb6d

• use latest id on insert

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  123843e

• save latest id to dict

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  ea06e77

• fix test_non_data_connections test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  63a67ec

• fix test_editor_duplicate_node test

  

  ElectronicBlueberry

  authored and

  dannon

  committed
  6e7585c

• fix event name for markdown update in PageEditorMarkdown component

  Show description for 85bde64
  

  davelopez

  authored and

  dannon

  committed
  85bde64

• Merge branch 'release_24.2' into merge_24.2_into_dev

  jmchilton

  committed
  4b3ee52

• Avoid unhelpful accepted format drop downs.

  jmchilton

  committed
  d59861f

• Upload on empty?

  jmchilton

  committed
  247d679

• add a message and link to upload tab if no initial elements

  Show description for 5dbf3b0
  ahmedhamidawan

  committed
  5dbf3b0

• Merge pull request galaxyproject#19241 from jmchilton/avoid_unhelpful_formats

  Show description for ef82f8f
  ahmedhamidawan

  authored
  ef82f8f

• remove useless "Cancel" buttons, add upload message

  ahmedhamidawan

  committed
  82b410a

Commits on Dec 4, 2024

• Pass redirect_uri back to authnz login

  dannon

  committed
  f6dad7b

• Add support for storing and retrieving login redirect URI in cookies

  dannon

  committed
  bafcc91

• Fix method sig, cleanup

  dannon

  committed
  66fc7a6

• fix rebased test function

  ElectronicBlueberry

  committed
  90e6393

• Merge pull request galaxyproject#19242 from jmchilton/improve_empty_message

  Show description for f5cb35c
  ahmedhamidawan

  authored
  f5cb35c

• Merge pull request galaxyproject#19212 from dannon/workflow-editor-activity-bar

  Show description for f47df34
  jdavcs

  authored
  f47df34

• Merge pull request galaxyproject#19247 from dannon/fix-psa-redirect

  Show description for 963ae52
  jdavcs

  authored
  963ae52

Commits on Dec 5, 2024

• Merge branch 'release_24.2' into merge_24.2_into_dev

  jmchilton

  committed
  67118bb