Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Build collection only if populated in collection builder #19250

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Dec 4, 2024

Fixes #19243

firefox_lILouMTE6Y

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Have a workflow input which creates a collection (list for e.g.)
    2. Click on the plus icon next to the form input
    3. Collection builder will open, try giving it a name and saving
    4. A confirmation dialog opens up that gives you the choice of creating an empty collection if that's what you want
    5. Clicking create will create it, cancel will take you back

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member

I was sort of hoping for a warning like "are you sure you want to do this" but then still allow it - like I said in the issue I think it should technically be possible. There are I think valid potential use cases for empty lists - like say you had a workflow that processed some data and then excluded intermediate steps if they matched some criteria defined by a list - in that case you might want an empty list to supply to the workflow.

@ahmedhamidawan
Copy link
Member Author

ahmedhamidawan commented Dec 4, 2024

@jmchilton Interesting, I wasn't aware of such use cases. Absolutely, we can add a link in those alerts use a confirmation dialog that will still allow creating the empty collection.

@ahmedhamidawan
Copy link
Member Author

@jmchilton I have added a confirmation dialog that still allows empty collection creation if that's what the user wants; the GIF above has the latest changes

@jmchilton
Copy link
Member

Wonderful - thank you so much - I really appreciate the work!

@jmchilton jmchilton merged commit 0f84879 into galaxyproject:release_24.2 Dec 5, 2024
33 checks passed
@jmchilton jmchilton added the release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them label Dec 5, 2024
@ahmedhamidawan ahmedhamidawan deleted the enforce_items_in_collection_builder branch December 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/bug release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants