Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Workflow Inputs Activity #19252

Conversation

ElectronicBlueberry
Copy link
Member

Moves inputs to it's own activity.
This will likely break a bunch of tests. Here's a picture:

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs
Copy link
Member

jdavcs commented Dec 4, 2024

This needs to target the dev branch, right? Also, the milestone should be 25.0?

@davelopez
Copy link
Contributor

@jdavcs In the last meeting we discussed this and the general consensus (as far as I remember) was to include this change as part of the Workflow Editor Activity Bar, for 2 reasons:

  • Users will get used to the new interface and then realize it was changed again raising confusion.
  • The change is small enough to be tested separately and/or in a second round.

@dannon
Copy link
Member

dannon commented Dec 5, 2024

Yes, @davelopez has the right recap, we want this in 24.2. Thank you @ElectronicBlueberry!

@dannon dannon added this to the 24.2 milestone Dec 5, 2024
@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review December 5, 2024 18:52
@jmchilton
Copy link
Member

"Single Dataset Input" seems like the wrong language for the top item description given that it can be a multiple="true" input. Feels cosmetic though - the backend changes all make sense to me and it is very good looking though. I like it and I appreciate the quick turn around for getting it into the release. Thank you so much!

@jmchilton jmchilton merged commit cb62d4c into galaxyproject:release_24.2 Dec 8, 2024
50 of 55 checks passed
Copy link

github-actions bot commented Dec 8, 2024

This PR was merged without a "kind/" label, please correct.

@jmchilton jmchilton added kind/enhancement release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them labels Dec 8, 2024
@@ -168,35 +161,6 @@ def editor(self, trans, id=None, workflow_id=None, version=None, **kwargs):
else:
new_workflow = True

# The following query loads all user-owned workflows,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 this is so much snappier on my test instance with thousands of workflows ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/client area/UI-UX area/workflows kind/enhancement release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants