-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.2] Workflow Inputs Activity #19252
[24.2] Workflow Inputs Activity #19252
Conversation
This needs to target the dev branch, right? Also, the milestone should be 25.0? |
@jdavcs In the last meeting we discussed this and the general consensus (as far as I remember) was to include this change as part of the Workflow Editor Activity Bar, for 2 reasons:
|
Yes, @davelopez has the right recap, we want this in 24.2. Thank you @ElectronicBlueberry! |
"Single Dataset Input" seems like the wrong language for the top item description given that it can be a multiple="true" input. Feels cosmetic though - the backend changes all make sense to me and it is very good looking though. I like it and I appreciate the quick turn around for getting it into the release. Thank you so much! |
This PR was merged without a "kind/" label, please correct. |
@@ -168,35 +161,6 @@ def editor(self, trans, id=None, workflow_id=None, version=None, **kwargs): | |||
else: | |||
new_workflow = True | |||
|
|||
# The following query loads all user-owned workflows, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 this is so much snappier on my test instance with thousands of workflows ...
Moves inputs to it's own activity.
This will likely break a bunch of tests. Here's a picture:
How to test the changes?
(Select all options that apply)
License