[24.2] Fix CollectionCreatorModal being reopened on history

[davelopez]

Fixes #19270

The CollectionCreatorModal.hideModal() function is only called on Cancel or when we explicitly set the prop hideModalOnCreate to true. If we don't set this prop, and we create a collection, it leaves the collectionModalShow ref set to true as the event to change it to false never gets fired.

@ahmedhamidawan do you think this might affect other usages of CollectionCreatorModal? Is there any use case for not setting hideModalOnCreate to true by default?

How to test the changes?

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[ahmedhamidawan]

The only reason you wouldn't set that prop to true would be if you wanted to see the collection you successfully created within the modal. But this use case in SelectionOperations was meant to have it as true, I might have overlooked that, so thank you!