Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UP031 errors - Part 5 #19282

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix UP031 errors - Part 5 #19282

merged 2 commits into from
Dec 9, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Dec 7, 2024

Also:

  • Add type annotations.
  • Small refactorings.

41 errors left after this, so the next one will be the last!

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Fix UP031 errors - Part 5
ff941b2 
Also:
- Add type annotations.
- Small refactorings.
@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Dec 7, 2024
@github-actions github-actions bot added area/jobs area/database Galaxy's database or data access layer area/datatypes labels Dec 7, 2024
@github-actions github-actions bot added this to the 25.0 milestone Dec 7, 2024
@nsoranzo
Prefer our package index server
8c4c296 
when running tests with tox that install dependencies from
requirements.txt files.

Workaround for astral-sh/uv#7496 .
@nsoranzo
Copy link
Member Author

nsoranzo commented Dec 8, 2024 •
edited
Loading

Test failures unrelated.

I've also added a commit to fix the mypy and test_galaxy_packages tests on Python 3.13 CI workflows, which have started to fail to build the pysam wheel (backported in #19284 ).

@nsoranzo nsoranzo requested a review from a team December 8, 2024 08:40
davelopez
davelopez approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@nsoranzo nsoranzo merged commit 7d25278 into galaxyproject:dev Dec 9, 2024
50 of 54 checks passed
@nsoranzo nsoranzo deleted the fix_UP031_errors_pt5 branch December 9, 2024 09:39
@nsoranzo nsoranzo mentioned this pull request Dec 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/datatypes area/jobs kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @davelopez