[24.2] Fix problem with multiple layers in workflow metrics. #19283
+333
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple bug fix - having two layers with their own y definitions cause both the correct label to appear in along the y-axis and just the letter "y". It also broke the descriptions of the values in the boxplot.
Before:
After:
This is a simple a bug fix for 24.2 and nothing more - it doesn't add aggregate pie charts that describe the portion of time the workflow spends in particular tools or steps, it doesn't add a version of the wall time metric scaled by the allocated core count (the metric you'd most want if you're worried about compute cost, hardware allocation, optimizing configurations, etc..), it doesn't color the charts so that the pie charts and the runtime graphs match, it doesn't offer the ability to measure everything in minutes (probably more natural for most users) or hours with a drop down, and it doesn't add nice help text for what the metrics mean providing more context for novice users. Wait no... it does do all those things... but we want to fix the axis so we have to take this commit. I think this version of the metrics will improve our researchers first impressions of the component with 24.2 also.
Context Help:
New Aggregate Metrics up front:
With Mouseover:
Switching unit to minutes:
Replaced Tabs with a dropdown to choose grouping.
How to test the changes?
(Select all options that apply)
License