Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix problem with multiple layers in workflow metrics. #19283

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jmchilton
Copy link
Member

Simple bug fix - having two layers with their own y definitions cause both the correct label to appear in along the y-axis and just the letter "y". It also broke the descriptions of the values in the boxplot.

Before:

Screenshot 2024-12-07 at 7 10 56 PM

After:

Screenshot 2024-12-07 at 7 08 35 PM

This is a simple a bug fix for 24.2 and nothing more - it doesn't add aggregate pie charts that describe the portion of time the workflow spends in particular tools or steps, it doesn't add a version of the wall time metric scaled by the allocated core count (the metric you'd most want if you're worried about compute cost, hardware allocation, optimizing configurations, etc..), it doesn't color the charts so that the pie charts and the runtime graphs match, it doesn't offer the ability to measure everything in minutes (probably more natural for most users) or hours with a drop down, and it doesn't add nice help text for what the metrics mean providing more context for novice users. Wait no... it does do all those things... but we want to fix the axis so we have to take this commit. I think this version of the metrics will improve our researchers first impressions of the component with 24.2 also.

Context Help:

Screenshot 2024-12-07 at 7 13 17 PM

New Aggregate Metrics up front:

Screenshot 2024-12-07 at 7 12 39 PM

With Mouseover:

Screenshot 2024-12-07 at 7 16 11 PM

Switching unit to minutes:

Screenshot 2024-12-07 at 7 12 44 PM Screenshot 2024-12-07 at 7 13 00 PM

Replaced Tabs with a dropdown to choose grouping.

Screenshot 2024-12-07 at 7 12 49 PM

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Open the metrics for a workflow and notice the y axis is fixed.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton requested a review from mvdbeek December 8, 2024 00:18
@jmchilton jmchilton added the release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them label Dec 8, 2024
@jmchilton jmchilton marked this pull request as ready for review December 8, 2024 16:57
@github-actions github-actions bot added this to the 25.0 milestone Dec 8, 2024
@mvdbeek mvdbeek merged commit ef968a7 into galaxyproject:release_24.2 Dec 9, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX area/workflows kind/bug kind/enhancement release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants