Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24.2] Fix workflow metrics chart style #19291

Merged
merged 4 commits into from
Dec 9, 2024
Merged

[24.2] Fix workflow metrics chart style #19291

merged 4 commits into from
Dec 9, 2024

Conversation

davelopez
Copy link
Contributor

Fixes #19289

Another set of enh... ehem! fixes for Workflow Invocation metrics:

  • Fixed the legend alignment issue. It now matches the one on the Vega editor.
  • Center the Pie Charts horizontally as much as I could.
  • Fixed the dropdown label for Group by. It was fixed to Tool ID.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez
Fix PieChart legend visual issue
1c6bece 
The "chart" class was braking Vega's CSS
@davelopez
Increase PieChart legend font size
e3ac780 
Slightly increase for improved visibility
@davelopez
Fix label for 'Group By' dropdown in Workflow Invocation Metrics
631da64 
Make it dynamic like the other one for time.
@davelopez
Center PieCharts horizontally
f07d673
@davelopez davelopez added kind/bug kind/enhancement area/UI-UX area/workflows release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them labels Dec 9, 2024
@github-actions github-actions bot added this to the 25.0 milestone Dec 9, 2024
@github-actions github-actions bot changed the title [24.02] Fix workflow metrics chart style [24.2] [24.02] Fix workflow metrics chart style Dec 9, 2024
@bgruening bgruening changed the title [24.2] [24.02] Fix workflow metrics chart style [24.2] Fix workflow metrics chart style Dec 9, 2024
@jmchilton
Copy link
Member

A million thanks - so much better! You're a magician.

@dannon dannon merged commit 5e7e78f into galaxyproject:release_24.2 Dec 9, 2024
31 checks passed
@ahmedhamidawan ahmedhamidawan mentioned this pull request Dec 9, 2024
Closed
@davelopez davelopez deleted the 24.02_fix_workflow_metrics_chart_style branch December 10, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannon dannon dannon approved these changes

Assignees
No one assigned
Labels
area/UI-UX area/workflows kind/bug kind/enhancement release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@davelopez @jmchilton @dannon