Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Use select_from_url test data from github, not usegalaxy.org #19352

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Dec 19, 2024

Should be more stable. Includes minor fix so JSON is decoded even if response headers indicate it's text.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot changed the title Use select_from_url test data from github, not usegalaxy.org [24.1] Use select_from_url test data from github, not usegalaxy.org Dec 19, 2024
@github-actions github-actions bot added this to the 24.1 milestone Dec 19, 2024
@nsoranzo
Copy link
Member

Framework test failure seems related.

@mvdbeek
Copy link
Member Author

mvdbeek commented Dec 19, 2024

yep, helps to use the right link

Co-authored-by: Nicola Soranzo <[email protected]>
@mvdbeek
Copy link
Member Author

mvdbeek commented Dec 19, 2024

I swear I had this working before I merged the test data and updates the branches 😅

@mvdbeek mvdbeek merged commit 724157f into galaxyproject:release_24.1 Dec 20, 2024
46 of 51 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Dec 20, 2024
@nsoranzo nsoranzo deleted the update_select_from_test branch December 30, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants