Make test reports more resilient to failing invocations #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't happening at the right place.
mvdbeek
force-pushed
the
robust_error_reports
branch
from
89c95e9 to
b5b1152
Compare
jmchilton
approved these changes
Oct 27, 2023
mvdbeek
force-pushed
the
robust_error_reports
branch
from
b5b1152 to
e834939
Compare
Maybe the shutdown takes too long if the tool still runs ?
mvdbeek
force-pushed
the
robust_error_reports
branch
from
045fdc1 to
6ff0811
Compare
mvdbeek
force-pushed
the
robust_error_reports
branch
from
6ff0811 to
11a7084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And show scheduling errors like the UI does.
Builds on #1399 for test fixes.
You can see an improved example here: https://gist.github.com/mvdbeek/9161e46b690e06fc71b9e77a66d638b2