writing_appliance script example: smiting perl from yet one more place #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexylena
reviewed
Jun 28, 2017
| gc = 0 | ||
| total = 0 | ||
| else: | ||
| gc += line.count('G') + line.count('C') |
There was a problem hiding this comment.
not case insensitive, unlike the perl version.
There was a problem hiding this comment.
True, true. Didn't know if it was more important to be complete or keep it simple. I can make the edit if you guys want.
hexylena
reviewed
Jun 28, 2017
| @@ -0,0 +1,20 @@ | |||
| #!/usr/bin/env python2 | |||
There was a problem hiding this comment.
Haha, I'd love to, but I figured let's not go crazy here.
There was a problem hiding this comment.
Actually, this made me do some research.. can OS X people confirm whether python2 is on your PATH?
There was a problem hiding this comment.
By default, no. At least only python is on the $PATH on macOS Sierra 10.12.5, not python2.
$ uname
Darwin
$ which python2
$ python2
-bash: python2: command not found
$ which python
/usr/bin/python
$ python --version
Python 2.7.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example script in https://planemo.readthedocs.io/en/latest/writing_appliance.html#wrapping-a-script was fine, but it was written in Perl (gasp). Why not Python, I thought?
Full disclosure: I haven't tested it, since I the build environment hasn't worked yet on my machine. But it's just a change in existing docs, what could go wrong? (famous last words)