Changes were made to volcano plot without changing the tool version, now workflows fail, please revert to version

[pcm32]

Hi there,

@paulzierep made some changes on the volcano plot tool recently, without changing the tool version by mistake. As a result, I have workflows failing now:

Could we please revert version 0.0.6 of volcano plot to its previous state and then push the rest of Paul's changes under a newer version number?

I currently get this in pipelines that I have been running without issues for months:

bioblend.ConnectionError: Unexpected HTTP status code: 400: {"err_msg": {"shape_col": "No value found for 'Categories that can be used to plot different shapes or facet (useful if multivariable associations are investigated)'.", "shape_or_facet"
: "No value found for 'Display categories by:'."}, "err_code": 0, "err_data": {"39": {"shape_col": "No value found for 'Categories that can be used to plot different shapes or facet (useful if multivariable associations are investigated)'.", "sh
ape_or_facet": "No value found for 'Display categories by:'."}}}

I suspect it is the last change that broke things somehow.

I'm suprised that the CI let this go.

[pcm32]

I found the issue, while a macro for versions was changed, this macro wasn't being used in the version field of the XML.

[pcm32]

Could someone with admin rights please re-instate the volcano plot version 0.0.6 in the toolshed to git revision 84949ce ? Thanks.

[paulzierep]

hi @pcm32 sorry for that, I just saw I mixed two tools, and only bumped another tool, big fail ! Hope it can be reverted, not sure if the is possible in the toolshed. If not we could push the revert as a new PR, and then you only need to change the tool version of your workflow.

[pcm32]

Thanks @paulzierep, no problem. I would prefer if someone with privileges re-states the adequate revision under that version on the toolshed, and then a new version number is pushed with your changes. I have various workflows in various versions (and other people might as well have, there is even an IWC workflow broken because of this), so I would prefer not to have to change them. Any admin who has the IUC user password for the toolshed should be able to push that older revision with that version there (I have done it in the past with my own user for my tools).

[bgruening]

@pcm32 can you test the latest version please?

[bgruening]

This needs to be merged next: #6622

[pcm32]

Thanks for this @bgruening . I need to wait for the CI to reinstall on those machines, I don't admin them, so I cannot force it, but it should run overnight and I can check tomorrow.

[bgruening]

Thanks!

[pcm32]

This seems to have worked, I don't get the warning of the field anymore when opening the workflow. Thanks!

[bgruening]

Thanks!